Add attempt event for sessionstate #5237
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PJB3005
requested changes
Jul 9, 2024
| var list = new List<SessionState>(); | ||
| var list = new List<SessionState>(players.Length); | ||
| var ev = new GetSessionStateAttempt(session); | ||
| _entityManager.EventBus.RaiseEvent(EventSource.Local, ref ev); |
There was a problem hiding this comment.
This isn't really simulation logic so using EventBus here doesn't really make a lot of sense. Just use a regular C# event?
| foreach (var client in players) | ||
| { | ||
| var info = new SessionState | ||
| { | ||
| UserId = client.UserId, | ||
| Name = client.Name, | ||
| Name = ev.Cancelled ? string.Empty : client.Name, |
There was a problem hiding this comment.
Isn't this just the player name? It doesn't seem very useful to try to hide this info when player names are just public from the auth API anyways.
| Status = client.Status, | ||
| Ping = client.Channel!.Ping | ||
| Ping = client.Channel.Ping, | ||
| ControlledEntity = EntManager.GetNetEntity(client.AttachedEntity), |
There was a problem hiding this comment.
Exposing the controlled entity seems very powerful, what use does this have for players?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.